Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets requiring other packages #40

Closed
lazappi opened this issue Jan 24, 2020 · 2 comments
Closed

Datasets requiring other packages #40

lazappi opened this issue Jan 24, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lazappi
Copy link
Owner

lazappi commented Jan 24, 2020

Below email received from CRAN

This concerns packages

DDPNA GCD GPoM Guerry HydroCode NMF NatureSounds RgoogleMaps
SpatialAcc TSP ade4 bamlss belg clustree datos dnet dsm gibble
glcm hypergate lctools link2GI nutshell.audioscrobbler ocedata palr
primerTree ragt2ridges rangemodelR rdwd serrsBayes smoothr spBayes
spData spaMM spatstat.data streamDepletr structSSI survivALL wpp2017 wpp2019

See the logs (and README.txt) at
https://www.stats.ox.ac.uk/pub/bdr/noSuggests/ .

At least one of the datasets cannot be loaded without a package declared
in Suggests: -- typically this is because it loads a namespace defining
S4 classes, and such imports should be declared in Imports or (as Matrix
does) use a .R wrapper. For example if I do

data('Sample_ID_data', package = 'DDPNA')
str(Sample_ID_data)

namespaces

BiocGenerics Biostrings IRanges S4Vectors XVector crayon zlibbioc

get loaded, pulled in by Biostrings so the latter has to be available.

Please correct ASAP and before Feb 20 to safely retain the package on CRAN.

@lazappi lazappi added the bug Something isn't working label Jan 24, 2020
@lazappi lazappi self-assigned this Jan 24, 2020
@lazappi
Copy link
Owner Author

lazappi commented Jan 27, 2020

Update from CRAN

This check is now also part of --as-cran and showing on the regular
fedora-clang checks on the package's results page (those at the URL
below are not being updated).

@lazappi
Copy link
Owner Author

lazappi commented Jan 27, 2020

sc_example$sc3_clusters is a DataFrame instead of a data.frame. Should be fairly easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant