Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any reason why sqlx-cli doesn't support symlinks? #2490

Closed
nxy7 opened this issue May 5, 2023 · 2 comments
Closed

Is there any reason why sqlx-cli doesn't support symlinks? #2490

nxy7 opened this issue May 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@nxy7
Copy link

nxy7 commented May 5, 2023

Hello, I'm using sqlx-cli inside container to run postgres migrations for my app (I like applying migrations separately, not with my main app). It worked great when I was using docker containers with volume binds. Lately I started migrating my app to kubernetes where volume binds are not the way to inject config into app. Instead You use ConfigMaps which are then injected into container as directory consisting of symlinks to content of ConfigMap. I think this caused my migrations container to 'break'. Is it something that could be supported by sqlx-cli or is there good reason to avoid it?

This is the code that I think is responsible for ignoring symlinks:

if !entry.metadata.is_file() {
// not a file; ignore
continue;
}

@nxy7 nxy7 added the enhancement New feature or request label May 5, 2023
@abonander
Copy link
Collaborator

I believe we have a pending fix for this in #2445

@nxy7
Copy link
Author

nxy7 commented May 5, 2023

Oh, great. I'll be waiting for it to get merged :-)

@nxy7 nxy7 closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants