Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regarding Optional.orElse #127

Closed
vimil opened this issue Mar 3, 2021 · 1 comment · Fixed by #128
Closed

Regarding Optional.orElse #127

vimil opened this issue Mar 3, 2021 · 1 comment · Fixed by #128
Assignees
@J-N-K
Labels
bug

Comments

@vimil
Copy link

vimil commented Mar 3, 2021 •
edited
Loading

with eclipse external annotations on Optional I see the below signature
@nonnull String @nonnull java.util.Optional.orElse(@nullable String other)
shouldn't this be
@nullable String @nonnull java.util.Optional.orElse(@nullable String other)

instead, as the javadoc for orElse states that the return type can be null if in the input parameter is null
@J-N-K J-N-K self-assigned this Mar 4, 2021
@J-N-K
Copy link
Member

J-N-K commented Mar 4, 2021

Correct

@J-N-K J-N-K added the bug label Mar 4, 2021
@J-N-K J-N-K mentioned this issue Mar 4, 2021
Merged
@J-N-K J-N-K mentioned this issue Jun 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@J-N-K J-N-K

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[java.util] fix Optional.orElse J-N-K/eclipse-null-eea-augments
2 participants
@vimil @J-N-K