diff --git a/xds/src/main/java/io/grpc/xds/SharedXdsClientPoolProvider.java b/xds/src/main/java/io/grpc/xds/SharedXdsClientPoolProvider.java index c4d5589e57c..595f17e8f56 100644 --- a/xds/src/main/java/io/grpc/xds/SharedXdsClientPoolProvider.java +++ b/xds/src/main/java/io/grpc/xds/SharedXdsClientPoolProvider.java @@ -28,7 +28,6 @@ import io.grpc.internal.TimeProvider; import io.grpc.xds.Bootstrapper.BootstrapInfo; import io.grpc.xds.XdsNameResolverProvider.XdsClientPoolFactory; -import io.grpc.xds.internal.security.TlsContextManagerImpl; import java.util.Map; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.atomic.AtomicReference; @@ -130,8 +129,7 @@ public XdsClient getObject() { scheduler, new ExponentialBackoffPolicy.Provider(), GrpcUtil.STOPWATCH_SUPPLIER, - TimeProvider.SYSTEM_TIME_PROVIDER, - new TlsContextManagerImpl(bootstrapInfo)); + TimeProvider.SYSTEM_TIME_PROVIDER); } refCount++; return xdsClient; diff --git a/xds/src/main/java/io/grpc/xds/XdsClientImpl.java b/xds/src/main/java/io/grpc/xds/XdsClientImpl.java index 17323396409..f2fceb603dd 100644 --- a/xds/src/main/java/io/grpc/xds/XdsClientImpl.java +++ b/xds/src/main/java/io/grpc/xds/XdsClientImpl.java @@ -47,6 +47,7 @@ import io.grpc.xds.XdsClient.TimerLaunch; import io.grpc.xds.XdsClient.XdsResponseHandler; import io.grpc.xds.XdsLogger.XdsLogLevel; +import io.grpc.xds.internal.security.TlsContextManagerImpl; import java.net.URI; import java.util.Collection; import java.util.Collections; @@ -116,8 +117,7 @@ public void uncaughtException(Thread t, Throwable e) { ScheduledExecutorService timeService, BackoffPolicy.Provider backoffPolicyProvider, Supplier stopwatchSupplier, - TimeProvider timeProvider, - TlsContextManager tlsContextManager) { + TimeProvider timeProvider) { this.xdsTransportFactory = xdsTransportFactory; this.bootstrapInfo = bootstrapInfo; this.context = context; @@ -125,7 +125,7 @@ public void uncaughtException(Thread t, Throwable e) { this.backoffPolicyProvider = backoffPolicyProvider; this.stopwatchSupplier = stopwatchSupplier; this.timeProvider = timeProvider; - this.tlsContextManager = checkNotNull(tlsContextManager, "tlsContextManager"); + this.tlsContextManager = new TlsContextManagerImpl(bootstrapInfo); logId = InternalLogId.allocate("xds-client", null); logger = XdsLogger.withLogId(logId); logger.log(XdsLogLevel.INFO, "Created"); diff --git a/xds/src/test/java/io/grpc/xds/XdsClientImplTestBase.java b/xds/src/test/java/io/grpc/xds/XdsClientImplTestBase.java index 4d714bf37d7..9f1be942eaf 100644 --- a/xds/src/test/java/io/grpc/xds/XdsClientImplTestBase.java +++ b/xds/src/test/java/io/grpc/xds/XdsClientImplTestBase.java @@ -287,8 +287,6 @@ public long currentTimeNanos() { private ResourceWatcher cdsResourceWatcher; @Mock private ResourceWatcher edsResourceWatcher; - @Mock - private TlsContextManager tlsContextManager; private ManagedChannel channel; private ManagedChannel channelForCustomAuthority; @@ -374,8 +372,7 @@ public XdsTransport create(ServerInfo serverInfo) { fakeClock.getScheduledExecutorService(), backoffPolicyProvider, fakeClock.getStopwatchSupplier(), - timeProvider, - tlsContextManager); + timeProvider); assertThat(resourceDiscoveryCalls).isEmpty(); assertThat(loadReportCalls).isEmpty(); @@ -3749,8 +3746,7 @@ private XdsClientImpl createXdsClient(String serverUri) { fakeClock.getScheduledExecutorService(), backoffPolicyProvider, fakeClock.getStopwatchSupplier(), - timeProvider, - tlsContextManager); + timeProvider); } private BootstrapInfo buildBootStrap(String serverUri) {