Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linkedIn] vanityName is missing in the linkedIn integration #380

Closed
ghost opened this issue Jul 15, 2019 · 1 comment
Closed

[linkedIn] vanityName is missing in the linkedIn integration #380

ghost opened this issue Jul 15, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 15, 2019

The vanityName from Basic Profile Fields is used to represent the public profile URL in the follow format: www.linkedin.com/in/{vanityName}.

This is missing in the current integration, would be nice to see this added.

@driesvints
Copy link
Member

I remember that when I refactored the linkedin integration that I needed to explicitly use the r_liteprofile scope instead of the r_basicprofile scope but I can't remember the reason why. The vanity name is included in the r_basicprofile but I'm unsure what the consequences would be of using that instead. I think at the worst it'll break people's apps because the integration will suddenly request more fields than the user has access to and prevent them from logging in.

Maybe it's better that we tackle #368 instead so you can explicitly set other scopes in your app. This would prevent the above problem. In any case the current scopes are enough for a basic login (which is the main purpose of socialite).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant