Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune command doesn't take expires_at into account #384

Closed
bjhijmans opened this issue Jul 28, 2022 · 3 comments · Fixed by #385
Closed

Prune command doesn't take expires_at into account #384

bjhijmans opened this issue Jul 28, 2022 · 3 comments · Fixed by #385
Labels
enhancement

Comments

@bjhijmans
Copy link

  • Sanctum Version: 3.0.0
  • Laravel Version: #.#.#
  • PHP Version: #.#.#
  • Database Driver & Version:

Description:

As mentioned here #252 (comment) the sanctum:prune-expired does not prune models based on their expires_at column, but only on the global sanctum.expiration config setting. This is counterintuitive and incorrect. The prune command should be updated for v3.
@driesvints
Copy link
Member

Can you send in a PR?

@bjhijmans
Copy link
Author

I don't have the time right now. I can look do it next week if nobody beats me to it. I just got notified about the comment because I made the expires_at PR and turned it into an issue.

@driesvints driesvints assigned driesvints and unassigned driesvints Jul 28, 2022
@iruoy iruoy mentioned this issue Jul 28, 2022
Merged
@driesvints
Copy link
Member

A PR was sent in for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prune expires_at tokens
2 participants
@driesvints @bjhijmans