Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions around terminology of SAIL_FILES #362

Closed
dragoonis opened this issue Mar 16, 2022 · 2 comments
Closed

Questions around terminology of SAIL_FILES #362

dragoonis opened this issue Mar 16, 2022 · 2 comments

Comments

@dragoonis
Copy link

  • Sail Version: Latest
  • Laravel Version: 9.x
  • PHP Version: 8.1
  • OS: Windows / Linux / macOS: N/A

Description:

I had a bug yesterday, around all bin/sail calls to docker-compose, not using custom docker-compose files (i.e: docker-compose -f )

I looked at the 1.x branch source and you've fixed that, I think?
export SAIL_FILES=${SAIL_FILES:-""}

These are DOCKER_COMPOSE_FILES really, rather than a new concept which is a SAIL_FILE which could be something different?

I was trying to explain to my team, today, that a SAIL_FILE is actually a DOCKER_COMPOSE_FILE, and I'm wondering if I'm correct, or I've overlooked some "sail magic" and it's not actually a docker-compose file, but something new?

Just looking for validation here, on naming

@driesvints
Copy link
Member

Can you please post the exact versions? I'll have a look as soon as I can.

@driesvints
Copy link
Member

SAIL_FILES was used to allow people to use override files. Please see #355 for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants