Not working on Laravel 9

[hosmelq]

Pulse Version

v1.0.0-beta2

Laravel Version

v9.52.16

PHP Version

8.2

Description

Pulse is not working since Benchmark::value was added in Laravel 10.

I can send a PR, but I want to know the best way. Maybe add the method in Laravel 9, add the value method directly to the RemembersQueries trait, or inline the code in the remember method.

Steps To Reproduce

Install Pulse in a Laravel 9 project.

[devajmeireles]

I suspect Pulse was designed for Laravel 10+ only.

[dlopez525]

@hosmelq What error did you get? blank page?

[dlopez525]

@devajmeireles I installed it in Laravel 10, but it doesn't work, I have been updating that app from Laravel 5.8. But in an app installed from Laravel 10, it works.

[hosmelq]

I suspect Pulse was designed for Laravel 10+ only.

It targets Laravel 9

pulse/composer.json

Line 21 in 3afeb3f

"illuminate/auth": "^9.0 || ^10.0",

I updated the RemembersQueries file in the vendor folder and verified that everything works correctly.

[dlopez525]

@hosmelq Could you explain what you did?

[crynobone]

I believe it was an oversight to add Laravel 9 support. Pulse require Livewire 3 which only support Laravel 10.

[dlopez525]

@crynobone I have an app in Laravel 10 and it doesn't work

[hosmelq]

I believe in was an oversight to add Laravel 9 support. Pulse require Livewire 3 which only support Laravel 10.

I agree with you. I'm sure they will remove the number 9 from the composer.json file.

[te1]

List of reasons why it doesn't work with Laravel 9 out of the box (that I found so far):

• Needs nunomaduro/collision 7.7 or newer (Laravel 9 uses ^6.1)
• Needs illuminate/support 10 (not enforced by composer.json right now)
  • Dashboard needs Illuminate\Support\Benchmark::value
  • php artisan pulse:check needs Illuminate\Support\Sleep

If you manually patch that it seems to work in Laravel 9. Still probably best to just enforce Laravel 10 though.

[jessarcher]

Thanks for the report. I don't think we can easily support Laravel 9 support so I'm going to close this one. #99 will hopefully make this clearer in future 👍