Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty files not matched recursively #160

Closed
valorin opened this issue Mar 23, 2023 · 1 comment · Fixed by #164
Closed

Dirty files not matched recursively #160

valorin opened this issue Mar 23, 2023 · 1 comment · Fixed by #164
Assignees

Comments

@valorin
Copy link

valorin commented Mar 23, 2023

  • Pint Version: 1.7.0
  • PHP Version: 8.1.16
  • Ubuntu Version: 20.04.5 LTS
  • Git Version: 2.25.1
  • Bash Version: 5.0.17

Description:

Pint appears to use the following command to find dirty files;:

git status --short -- *.php

However, on Ubuntu with Git and Bash, that only returns matches from the current level:

$ git status --short
 M _ide_helper.php
 M composer.json
 M composer.lock
 M package-lock.json
 M public/vendor/horizon/app.js
 M public/vendor/horizon/mix-manifest.json
 M resources/views/attack.blade.php
 M resources/views/modules/attack/csrf/challenges.blade.php
 M resources/views/target/csrf.blade.php

$ git status --short -- *.php
 M _ide_helper.php

In order to match files recursively, I need to do this:

$ git status --short -- "**.php"
 M _ide_helper.php
 M resources/views/attack.blade.php
 M resources/views/modules/attack/csrf/challenges.blade.php
 M resources/views/target/csrf.blade.php

I am guessing the issue is different matching rules for different platforms. The "**.php" looks more robust at a glance, but I don't have other environments to test on to confirm.

@nunomaduro
Copy link
Member

Made pull request to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants