From 45e7973a2a9b9a489ba8e7dbeffb88a0b7c5bc41 Mon Sep 17 00:00:00 2001 From: Joe Campo Date: Wed, 9 Feb 2022 14:29:38 -0500 Subject: [PATCH] Fix Support\Collection reject method type definition --- src/Illuminate/Collections/Enumerable.php | 2 +- src/Illuminate/Collections/Traits/EnumeratesValues.php | 2 +- types/Support/Collection.php | 6 ++++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/Illuminate/Collections/Enumerable.php b/src/Illuminate/Collections/Enumerable.php index 8ae296bd6982..0ad48def0f7d 100644 --- a/src/Illuminate/Collections/Enumerable.php +++ b/src/Illuminate/Collections/Enumerable.php @@ -1099,7 +1099,7 @@ public function pluck($value, $key = null); /** * Create a collection of all elements that do not pass a given truth test. * - * @param (callable(TValue): bool)|bool $callback + * @param (callable(TValue, TKey): bool)|bool $callback * @return static */ public function reject($callback = true); diff --git a/src/Illuminate/Collections/Traits/EnumeratesValues.php b/src/Illuminate/Collections/Traits/EnumeratesValues.php index b328e79251bb..7a48c0a80e69 100644 --- a/src/Illuminate/Collections/Traits/EnumeratesValues.php +++ b/src/Illuminate/Collections/Traits/EnumeratesValues.php @@ -788,7 +788,7 @@ class_basename(static::class), gettype($result) /** * Create a collection of all elements that do not pass a given truth test. * - * @param (callable(TValue): bool)|bool $callback + * @param (callable(TValue, TKey): bool)|bool $callback * @return static */ public function reject($callback = true) diff --git a/types/Support/Collection.php b/types/Support/Collection.php index 4e09d4197180..e4603d1d6e37 100644 --- a/types/Support/Collection.php +++ b/types/Support/Collection.php @@ -735,6 +735,12 @@ return true; })); +assertType('Illuminate\Support\Collection', $collection->reject(function ($user, $int) { + assertType('User', $user); + assertType('int', $int); + + return true; +})); assertType('Illuminate\Support\Collection', $collection->unique()); assertType('Illuminate\Support\Collection', $collection->unique(function ($user, $int) {