From f1c491086c0d0d2eda2dd3394ea41d562ff1f36f Mon Sep 17 00:00:00 2001 From: Leonardo Nodari Date: Sat, 2 May 2020 15:39:31 +0200 Subject: [PATCH] Remove wasted file read when loading package manifest Filesystem get was introduced in commit 683637a5c0d8ee0049e9067785175f9a291e824e as a locking mechanism to prevent partial reads of the manifest file. In commit 633a907bf974d303a2ee19eef070efdc6150ca2c the locking was substituted by an atomic rename-based file write. The get called survived the refactor, resulting a noop file_get_contents that just trashes the output. This commit removes the read entirely. --- src/Illuminate/Foundation/PackageManifest.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Illuminate/Foundation/PackageManifest.php b/src/Illuminate/Foundation/PackageManifest.php index a761cf6f742b..9356cef026bb 100644 --- a/src/Illuminate/Foundation/PackageManifest.php +++ b/src/Illuminate/Foundation/PackageManifest.php @@ -106,8 +106,6 @@ protected function getManifest() $this->build(); } - $this->files->get($this->manifestPath); - return $this->manifest = file_exists($this->manifestPath) ? $this->files->getRequire($this->manifestPath) : []; }