Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runPaginationCountQuery works wrong for union query with limit and offset #38639

Closed
vismutx opened this issue Sep 1, 2021 · 3 comments
Closed

Comments

@vismutx
Copy link

vismutx commented Sep 1, 2021

  • Laravel Version: 8.58.0
  • PHP Version: 8.0
  • Database Driver & Version: MYSQL

Description:

in \Illuminate\Database\Query\Builder::runPaginationCountQuery
we have code

...
        $without = $this->unions ? ['orders', 'limit', 'offset'] : ['columns', 'orders', 'limit', 'offset'];
        $this->cloneWithout($without)
...

But problem is, that Union use unionLimit and unionOffset
So cloneWithout method don't clear query object from unionLimit and unionOffset

Steps To Reproduce:

Just create any union query and do

$queryUnion->union($query)
$queryUnion->offset(0)->limit(5)
$queryUnion->toBase()->getCountForPagination()

crutch I used to make my code work

$queryUnion->union($query);
$queryUnion->offset(0)->limit(5);
$unionBaseQuery = $queryUnion->toBase();
$unionBaseQuery = clone $unionBaseQuery;
$unionBaseQuery->unionLimit = null;
$unionBaseQuery->unionOffset = null;
$unionBaseQuery->getCountForPagination();
@driesvints
Copy link
Member

Heya, thanks for reporting.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as separate commits on the main/master branch and share the repository here? Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Please do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

@vismutx
Copy link
Author

vismutx commented Sep 2, 2021

Really need it for this simple issue?
It will take 1+ hour, will have time only next week.

@driesvints
Copy link
Member

Feel free to reopen a new issue when you've managed to set up a repo 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants