Downloading large files gives out of memory errors

[sebsel]

• Laravel Version: 6.5.2
• PHP Version: 7.4.0

Description:

This bug manifested itself when I pointed Laravel Nova's File field to a file of 1,04 GB. Nova is unable to download those files. The log shows an out-of-memory error.

I investigated the problem and I think it lies with Illuminate\Filesystem\FilesystemAdapter, which uses a fpasstru() of the stream.

framework/src/Illuminate/Filesystem/FilesystemAdapter.php

Lines 163 to 167 in f3c1f48

	$response->setCallback(function () use ($path) {
	$stream = $this->readStream($path);
	fpassthru($stream);
	fclose($stream);
	});

This loads the whole file in memory. The following would work:

        $response->setCallback(function () use ($path) {
            $stream = $this->readStream($path);
            while (! feof($stream)) {
                echo fread($stream, 2048);
            }
            fclose($stream);
        });

Steps To Reproduce:

Get yourself a large file and point a tinker session to it:

>>> Storage::download('large-file.csv')->send()

With fpassthru(), you get a "Allowed memory size of 134217728 bytes exhausted (tried to allocate 1041674240 bytes)".
With the while loop it just streams data.

Happy to PR.

---

Credits: https://www.php.net/manual/en/function.fpassthru.php#29162
More examples on that page too.

[taylorotwell]

Feel free to send in a PR. Thanks.

[driesvints]

PR was merged.

[cameronjohnson-mz]

@driesvints how come this change isn't in Laravel 9.x? How do I apply this fix to my vendor files?

https://github.com/laravel/framework/blob/9.x/src/Illuminate/Filesystem/FilesystemAdapter.php#L298

[sebsel]

Because it was reverted, see the PR: #31163 (comment)

[HDVinnie]

This is still an issue....