Skip to content

Commit bd0e7cc

Browse files
authored
Refine error messages for detecting lost connections (#53794)
Last year I added those two via #47398 Please see details and reasoning there, it still applies; TL;DR: > Ever since I moved from AWS Aurora to using AWS RDS Proxy, which > (similar to pgbouncer) is essential to not overload the primary database > with connection, I sporadically see these messages. This affects > scheduled tasks, worker, HTTP requests; it's across the whole board. What I didn't knew back then was that the order/format of those messages very much dependent on the underlying libraries (libpq and or libssl presumably) and once we started to upgrade from Debian bullseye to bookworm, they changed and now are randomly interrupting our service again. The new (complete) messages look like this: > `SQLSTATE[08006] [7] connection to server at "…" (…), port 5… failed: SSL error: sslv3 alert unexpected message (Connection: main, SQL: …` That is, it still contains "SSL error: sslv3 alert unexpected message" but there's now connection specific information before the SQLSTATE prefix. Since lost connection detection is based on exact string matching and not regex, we're just removing the magic numbers in front and still keep backwards compatibility. I opened this PR against Laravel 10.x because we're still using and it requires the fix there (we're in the progress moving to L11, but it still takes time). Thanks
1 parent 3dcbda2 commit bd0e7cc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Illuminate/Database/DetectsLostConnections.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ protected function causedByLostConnection(Throwable $e)
6464
'Reason: Server is in script upgrade mode. Only administrator can connect at this time.',
6565
'Unknown $curl_error_code: 77',
6666
'SSL: Handshake timed out',
67-
'SQLSTATE[08006] [7] SSL error: sslv3 alert unexpected message',
68-
'SQLSTATE[08006] [7] unrecognized SSL error code:',
67+
'SSL error: sslv3 alert unexpected message',
68+
'unrecognized SSL error code:',
6969
'SQLSTATE[HY000] [2002] No connection could be made because the target machine actively refused it',
7070
'SQLSTATE[HY000] [2002] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond',
7171
'SQLSTATE[HY000] [2002] Network is unreachable',

0 commit comments

Comments
 (0)