From 5cabd321fd0d79762a4479f9572e65e843ff7c3c Mon Sep 17 00:00:00 2001 From: Cam Kemshal-Bell Date: Wed, 14 Aug 2024 23:29:09 +1000 Subject: [PATCH] test(dim-ratio): update condition where full ratio not provided in test (edge-case) --- tests/Validation/ValidationValidatorTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/Validation/ValidationValidatorTest.php b/tests/Validation/ValidationValidatorTest.php index a376ccd0991..6e5ac7ffa17 100755 --- a/tests/Validation/ValidationValidatorTest.php +++ b/tests/Validation/ValidationValidatorTest.php @@ -5018,9 +5018,11 @@ public function testValidateImageDimensions() $v = new Validator($trans, ['x' => $uploadedFile], ['x' => 'dimensions:ratio=1']); $this->assertFalse($v->passes()); + // evaluates to (64 / 65) > (1 / 1.0) which is true/fails $v = new Validator($trans, ['x' => $uploadedFile], ['x' => 'dimensions:min_ratio=1']); - $this->assertFalse($v->passes()); + $this->assertFalse($v->fails()); + // evaluates to (64 / 65) < (1 / 1.0) which is false/passes $v = new Validator($trans, ['x' => $uploadedFile], ['x' => 'dimensions:max_ratio=1']); $this->assertFalse($v->passes());