You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to make a PR to this repository to add the Toolkit for interaction with Google Calendar, my main inspiration from the source code is the Gmail Toolkit, but I have some doubts about how to meet the requirements of the PR template and the different guides, I hope you can help me to make the PR push as soon as possible.
According to the README, as it's a functionality that makes API calls you have to do the integration tests, but there are no integration tests for the Gmail Toolkit with which I can guide me, because unlike other GPC tools, in these services, you don't have access with a simple API key.
Another question about this PR that I have doubts about is related to the development experience, the idea is that the Calendar Toolkit can be installed in a similar way as the Gmail Toolkit is installed:
Can I propose this in the PR? Why does the README mention that to add a dependency I have to do it with the extended_testing_deps.txt file
Open extended_testing_deps.txt and add the dependency
Add a unit test that the very least attempts to import the new code. Ideally, the unit test makes use of lightweight fixtures to test the logic of the code.
Please use the @pytest.mark.requires(package_name) decorator for any unit tests that require the dependency.
But there isn't extended_testing_deps.txt file.
My last question is about the notebooks for new integrations that are mentioned in the
PR template:
If adding a new integration:
Include a test for the integration (preferably unit tests that do not rely on network access)
Add an example notebook showing its use (place in the docs/docs/integrations directory)
But again this route does not exist.
Thanks devs, and I hope you can help me to make this contribution 🤩
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hello there!
I want to make a PR to this repository to add the Toolkit for interaction with Google Calendar, my main inspiration from the source code is the Gmail Toolkit, but I have some doubts about how to meet the requirements of the PR template and the different guides, I hope you can help me to make the PR push as soon as possible.
According to the README, as it's a functionality that makes API calls you have to do the integration tests, but there are no integration tests for the Gmail Toolkit with which I can guide me, because unlike other GPC tools, in these services, you don't have access with a simple API key.
Another question about this PR that I have doubts about is related to the development experience, the idea is that the Calendar Toolkit can be installed in a similar way as the Gmail Toolkit is installed:
To achieve this, the following would need to be added to
langchain-google/libs/community/pyproject.toml
:Can I propose this in the PR? Why does the README mention that to add a dependency I have to do it with the
extended_testing_deps.txt
fileBut there isn't
extended_testing_deps.txt
file.My last question is about the notebooks for new integrations that are mentioned in the
PR template:
But again this route does not exist.
Thanks devs, and I hope you can help me to make this contribution 🤩
Beta Was this translation helpful? Give feedback.
All reactions