Skip to content

Commit 7920ecf

Browse files
authored
ci(python): stop using deprecated 2_24 manylinux for arm (#2064)
Based on changes made in Lance: * lancedb/lance#3409 * lancedb/lance#3411
1 parent 28e1b70 commit 7920ecf

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

.github/workflows/build_linux_wheel/action.yml

+2-7
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,7 @@ runs:
5252
args: ${{ inputs.args }}
5353
before-script-linux: |
5454
set -e
55-
apt install -y unzip
56-
if [ $(uname -m) = "x86_64" ]; then
57-
PROTOC_ARCH="x86_64"
58-
else
59-
PROTOC_ARCH="aarch_64"
60-
fi
61-
curl -L https://github.com/protocolbuffers/protobuf/releases/download/v24.4/protoc-24.4-linux-$PROTOC_ARCH.zip > /tmp/protoc.zip \
55+
yum install -y openssl-devel clang \
56+
&& curl -L https://github.com/protocolbuffers/protobuf/releases/download/v24.4/protoc-24.4-linux-aarch_64.zip > /tmp/protoc.zip \
6257
&& unzip /tmp/protoc.zip -d /usr/local \
6358
&& rm /tmp/protoc.zip

.github/workflows/pypi-publish.yml

+10-4
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,21 @@ jobs:
1515
- platform: x86_64
1616
manylinux: "2_17"
1717
extra_args: ""
18+
runner: ubuntu-22.04
1819
- platform: x86_64
1920
manylinux: "2_28"
2021
extra_args: "--features fp16kernels"
22+
runner: ubuntu-22.04
2123
- platform: aarch64
22-
manylinux: "2_24"
24+
manylinux: "2_17"
2325
extra_args: ""
24-
# We don't build fp16 kernels for aarch64, because it uses
25-
# cross compilation image, which doesn't have a new enough compiler.
26-
runs-on: "ubuntu-22.04"
26+
# For successful fat LTO builds, we need a large runner to avoid OOM errors.
27+
runner: ubuntu-2404-8x-arm64
28+
- platform: aarch64
29+
manylinux: "2_28"
30+
extra_args: "--features fp16kernels"
31+
runner: ubuntu-2404-8x-arm64
32+
runs-on: ${{ matrix.config.runner }}
2733
steps:
2834
- uses: actions/checkout@v4
2935
with:

0 commit comments

Comments
 (0)