From f803ca3110eaf6da52a14b409f62d7da351aa54b Mon Sep 17 00:00:00 2001 From: Weston Pace Date: Mon, 21 Oct 2024 12:15:10 -0700 Subject: [PATCH] ci: fix version check CI job (#3032) Part of the job checks out the pull request (this isn't done automatically because this runs with `pull_request_target` which checks out the base by default). That step was using `merge_commit_sha` which is not correct (this still checks out the base). The fix instead checks out `head.sha` which is correct. It is not possible to get a `merge_commit_sha` (there is a request for this [here](https://github.com/actions/checkout/issues/518)) but `head.sha` should be good enough for our purposes. --- .github/workflows/pr-title.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-title.yml b/.github/workflows/pr-title.yml index 80d75b0c30..dc404a1441 100644 --- a/.github/workflows/pr-title.yml +++ b/.github/workflows/pr-title.yml @@ -36,7 +36,7 @@ jobs: with: # pull_request_target checks out the base branch by default, not # the PR branch. - ref: "${{ github.event.pull_request.merge_commit_sha }}" + ref: "${{ github.event.pull_request.head.sha }}" path: pr - uses: actions/setup-python@v5 with: