Skip to content

Commit 6756a12

Browse files
lyang24BubbleCal
andauthored
chore(api)!: remove unused param in take call (#3453)
Related to #3444 Removed unused kwargs parameter in [LanceDataset.take](https://github.com/lancedb/lance/blob/main/python/python/lance/dataset.py#L791) --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com> Co-authored-by: BubbleCal <bubble-cal@outlook.com>
1 parent 7f91eb0 commit 6756a12

File tree

5 files changed

+47
-50
lines changed

5 files changed

+47
-50
lines changed

Cargo.lock

+16-16
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+17-17
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ exclude = ["python"]
2121
resolver = "2"
2222

2323
[workspace.package]
24-
version = "0.23.3"
24+
version = "0.24.0"
2525
edition = "2021"
2626
authors = ["Lance Devs <dev@lancedb.com>"]
2727
license = "Apache-2.0"
@@ -44,21 +44,21 @@ categories = [
4444
rust-version = "1.80.1"
4545

4646
[workspace.dependencies]
47-
lance = { version = "=0.23.3", path = "./rust/lance" }
48-
lance-arrow = { version = "=0.23.3", path = "./rust/lance-arrow" }
49-
lance-core = { version = "=0.23.3", path = "./rust/lance-core" }
50-
lance-datafusion = { version = "=0.23.3", path = "./rust/lance-datafusion" }
51-
lance-datagen = { version = "=0.23.3", path = "./rust/lance-datagen" }
52-
lance-encoding = { version = "=0.23.3", path = "./rust/lance-encoding" }
53-
lance-encoding-datafusion = { version = "=0.23.3", path = "./rust/lance-encoding-datafusion" }
54-
lance-file = { version = "=0.23.3", path = "./rust/lance-file" }
55-
lance-index = { version = "=0.23.3", path = "./rust/lance-index" }
56-
lance-io = { version = "=0.23.3", path = "./rust/lance-io" }
57-
lance-jni = { version = "=0.23.3", path = "./java/core/lance-jni" }
58-
lance-linalg = { version = "=0.23.3", path = "./rust/lance-linalg" }
59-
lance-table = { version = "=0.23.3", path = "./rust/lance-table" }
60-
lance-test-macros = { version = "=0.23.3", path = "./rust/lance-test-macros" }
61-
lance-testing = { version = "=0.23.3", path = "./rust/lance-testing" }
47+
lance = { version = "=0.24.0", path = "./rust/lance" }
48+
lance-arrow = { version = "=0.24.0", path = "./rust/lance-arrow" }
49+
lance-core = { version = "=0.24.0", path = "./rust/lance-core" }
50+
lance-datafusion = { version = "=0.24.0", path = "./rust/lance-datafusion" }
51+
lance-datagen = { version = "=0.24.0", path = "./rust/lance-datagen" }
52+
lance-encoding = { version = "=0.24.0", path = "./rust/lance-encoding" }
53+
lance-encoding-datafusion = { version = "=0.24.0", path = "./rust/lance-encoding-datafusion" }
54+
lance-file = { version = "=0.24.0", path = "./rust/lance-file" }
55+
lance-index = { version = "=0.24.0", path = "./rust/lance-index" }
56+
lance-io = { version = "=0.24.0", path = "./rust/lance-io" }
57+
lance-jni = { version = "=0.24.0", path = "./java/core/lance-jni" }
58+
lance-linalg = { version = "=0.24.0", path = "./rust/lance-linalg" }
59+
lance-table = { version = "=0.24.0", path = "./rust/lance-table" }
60+
lance-test-macros = { version = "=0.24.0", path = "./rust/lance-test-macros" }
61+
lance-testing = { version = "=0.24.0", path = "./rust/lance-testing" }
6262
approx = "0.5.1"
6363
# Note that this one does not include pyarrow
6464
arrow = { version = "53.2", optional = false, features = ["prettyprint"] }
@@ -114,7 +114,7 @@ datafusion-physical-expr = { version = "44.0" }
114114
deepsize = "0.2.0"
115115
dirs = "5.0.0"
116116
either = "1.0"
117-
fsst = { version = "=0.23.3", path = "./rust/lance-encoding/src/compression_algo/fsst" }
117+
fsst = { version = "=0.24.0", path = "./rust/lance-encoding/src/compression_algo/fsst" }
118118
futures = "0.3"
119119
http = "1.1.0"
120120
hyperloglogplus = { version = "0.4.1", features = ["const-loop"] }

python/Cargo.lock

+13-13
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "pylance"
3-
version = "0.23.3"
3+
version = "0.24.0"
44
edition = "2021"
55
authors = ["Lance Devs <dev@lancedb.com>"]
66
rust-version = "1.65"

python/python/lance/dataset.py

-3
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,6 @@ def take(
792792
self,
793793
indices: Union[List[int], pa.Array],
794794
columns: Optional[Union[List[str], Dict[str, str]]] = None,
795-
**kwargs,
796795
) -> pa.Table:
797796
"""Select rows of data by index.
798797
@@ -804,8 +803,6 @@ def take(
804803
List of column names to be fetched.
805804
Or a dictionary of column names to SQL expressions.
806805
All columns are fetched if None or unspecified.
807-
**kwargs : dict, optional
808-
See :py:method::scanner method for full parameter description.
809806
810807
Returns
811808
-------

0 commit comments

Comments
 (0)