chore: update clippy suggestions (#3495)

Some new suggestions were adding in 1.85 and they are tripping up CI
builds

We need to temporarily ignore `useless_conversion` until we're able to
upgrade arrow due to
rust-lang/rust-clippy#12039

We need to temporarily pin `chrono` until we're able to upgrade arrow
due to chronotope/chrono#1666

Author: westonpace

Cargo.lock

@@ -85,7 +85,9 @@ bitvec = "1"
 bytes = "1.4"
 byteorder = "1.5"
 clap = { version = "4", features = ["derive"] }
-chrono = { version = "0.4.25", default-features = false, features = [
+# Version temporarily pinned to work around unlabeled breaking change
+# https://github.com/apache/arrow-rs/commit/2fddf85afcd20110ce783ed5b4cdeb82293da30b
+chrono = { version = "=0.4.39", default-features = false, features = [
     "std",
     "now",
 ] }

Cargo.toml

@@ -18,6 +18,10 @@
 //! automatic versioning, optimized for computer vision, bioinformatics, spatial and ML data.
 //! [Apache Arrow](https://arrow.apache.org/) and DuckDB compatible.
 
+// Workaround for https://github.com/rust-lang/rust-clippy/issues/12039
+// Remove after upgrading pyo3 to 0.23
+#![allow(clippy::useless_conversion)]
+
 use std::env;
 use std::sync::Arc;
 

python/Cargo.lock

@@ -72,9 +72,10 @@ impl Scanner {
     fn analyze_plan(self_: PyRef<'_, Self>) -> PyResult<String> {
         let scanner = self_.scanner.clone();
         let res = RT
-            .spawn(Some(self_.py()), async move {
-                scanner.analyze_plan().await
-            })?
+            .spawn(
+                Some(self_.py()),
+                async move { scanner.analyze_plan().await },
+            )?
             .map_err(|err| PyValueError::new_err(err.to_string()))?;
 
         Ok(res)

python/src/lib.rs

@@ -518,7 +518,8 @@ impl RowIdTreeMap {
     ///   * u32: fragment_id
     ///   * u32: bitmap size
     ///   * \[u8\]: bitmap
-    ///     If bitmap size is zero then the entire fragment is selected.
+    ///
+    /// If bitmap size is zero then the entire fragment is selected.
     pub fn serialize_into<W: Write>(&self, mut writer: W) -> Result<()> {
         writer.write_u32::<byteorder::LittleEndian>(self.inner.len() as u32)?;
         for (fragment, set) in &self.inner {

python/src/scanner.rs

@@ -816,7 +816,7 @@ impl Planner {
         for i in (start_idx..hex_bytes.len()).step_by(2) {
             let high = Self::try_decode_hex_char(hex_bytes[i])?;
             let low = Self::try_decode_hex_char(hex_bytes[i + 1])?;
-            decoded_bytes.push(high << 4 | low);
+            decoded_bytes.push((high << 4) | low);
         }
 
         Some(decoded_bytes)

rust/lance-core/src/utils/mask.rs

@@ -38,7 +38,7 @@ const FSST_HASH_PRIME: u64 = 2971215073;
 const FSST_SHIFT: usize = 15;
 #[inline]
 fn fsst_hash(w: u64) -> u64 {
-    w.wrapping_mul(FSST_HASH_PRIME) ^ (w.wrapping_mul(FSST_HASH_PRIME)) >> FSST_SHIFT
+    w.wrapping_mul(FSST_HASH_PRIME) ^ ((w.wrapping_mul(FSST_HASH_PRIME)) >> FSST_SHIFT)
 }
 
 const MAX_SYMBOL_LENGTH: usize = 8;
@@ -119,7 +119,7 @@ impl Symbol {
         Self {
             val: c as u64,
             // in a symbol which represents a single character, 56 bits(7 bytes) are ignored, code length is 1
-            icl: (1 << CODE_LEN_SHIFT_IN_ICL) | (code as u64) << CODE_SHIFT_IN_ICL | 56,
+            icl: (1 << CODE_LEN_SHIFT_IN_ICL) | ((code as u64) << CODE_SHIFT_IN_ICL) | 56,
         }
     }
 
@@ -368,7 +368,7 @@ impl SymbolTable {
             return self.byte_codes[input[0] as usize] & FSST_CODE_MASK;
         }
         if len == 2 {
-            let short_code = (input[1] as usize) << 8 | input[0] as usize;
+            let short_code = ((input[1] as usize) << 8) | input[0] as usize;
             if self.short_codes[short_code] >= FSST_CODE_BASE {
                 return self.short_codes[short_code] & FSST_CODE_MASK;
             } else {
@@ -1053,9 +1053,9 @@ impl FsstEncoder {
         let st = &self.symbol_table;
 
         let st_info: u64 = FSST_MAGIC
-            | (self.encoder_switch as u64) << 24
-            | ((st.suffix_lim & 255) as u64) << 16
-            | ((st.terminator & 255) as u64) << 8
+            | ((self.encoder_switch as u64) << 24)
+            | (((st.suffix_lim & 255) as u64) << 16)
+            | (((st.terminator & 255) as u64) << 8)
             | ((st.n_symbols & 255) as u64);
 
         let st_info_bytes = st_info.to_ne_bytes();