Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Curators and Curator CI #2303

Open
7 tasks
Zethson opened this issue Dec 19, 2024 · 3 comments
Open
7 tasks

Reorganize Curators and Curator CI #2303

Zethson opened this issue Dec 19, 2024 · 3 comments

Comments

@Zethson
Copy link
Member

Zethson commented Dec 19, 2024

Add a description

Based on #2290 (comment)

  • Discuss pros/cons of keeping logic in nox + using paths changed like introduced in ✨ Add SpatialDataCurator #2290 vs writing new workflow files that run conditioned on path (like we do in laminhub)
  • Can we return a 'skip' for skipped paths?
  • Break out the TiledbsomaCurator similar to the SpatialDataCurator
  • Revamp the API to get rid of the from_ pattern and introduce proper Curator classes instead
  • Put these into a curator module
  • Reorganize the docs accordingly to also ensure that all Curator have sufficient information for users
  • Create a curator folder in the tests and run those
@Koncopd
Copy link
Member

Koncopd commented Dec 19, 2024

Could you also a quck thing of moving the curator tests from core to its own folder?

f"pytest {coverage_args} tests/core/test_curator.py -k test_spatialdata_curator --durations=50",

@Zethson
Copy link
Member Author

Zethson commented Dec 19, 2024

Ah yes, sorry, I forgot to add that to the tasks. I had an interation of that in my PR.

@falexwolf
Copy link
Member

falexwolf commented Jan 11, 2025

#2340 (comment)

Edit Lukas: #2340 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants