fix TypeError: fclose(): supplied resource is not a valid stream reso…

[remicollet]

No description provided.

[glensc]

FYI, in zf1s zf1s/zf1#32 handled as

diff --git a/packages/zend-mail/library/Zend/Mail/Storage/Mbox.php b/packages/zend-mail/library/Zend/Mail/Storage/Mbox.php
index 90e3791c..de963804 100644
--- a/packages/zend-mail/library/Zend/Mail/Storage/Mbox.php
+++ b/packages/zend-mail/library/Zend/Mail/Storage/Mbox.php
@@ -335,7 +335,9 @@ class Zend_Mail_Storage_Mbox extends Zend_Mail_Storage_Abstract
      */
     public function close()
     {
-        @fclose($this->_fh);
+        if ($this->_fh && 'Unknown' !== get_resource_type($this->_fh)) {
+            @fclose($this->_fh);
+        }
         $this->_positions = array();
     }

[remicollet]

@glensc sorry, don't understand your comment

[remicollet]

Notice there is also tons of Warning: Undefined array key 1 ... related to bad explode usage in various place

[remicollet]

I really think this component is NOT yet compatible with PHP 8

[glensc]

@glensc sorry, don't understand your comment

my comment is informative, take or leave it. FYI stands for For Your Information.

[glensc]

I really think this component is NOT yet compatible with PHP 8

You should set your PR status to Draft while it's not ready for merge.

[remicollet]

It is ready to merge as it fixes the test suite.

Remaining warnings have to be fixed, but out of the scope of this issue

[Ocramius]

I really think this component is NOT yet compatible with PHP 8

Can't do much about that besides pursuing further issues, like #113 :-\

I see that travis-ci completely abandoned us today :-(

[glensc]

yes, travis gone already yesterday:

• [RFC]: Migrate CI from Travis to GitHub Actions #133