Psalm integration

[boesing]

Feature Request

Q	A
QA	yes

Summary

As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.

Implementing psalm is quite easy.

Required

• Create a .psalm.xml.dist in the project root
• Copy and paste the contents from this psalm.xml.dist
• Run $ composer require vimeo/psalm
• Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
• Add a composer script static-analysis with the command psalm --shepherd --stats
• Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
• Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Optional

• Fix as many psalm errors as possible.

[gennadiylitvinyuk]

I think composer.lock should be deleted from repository. This is a library at the end...

[boesing]

It is, but we decided to have it available for QA checks like codestandard and psalm as these libraries constantly detecting new stuff in newer versions when these are being updated during CI.

So instead of locking these libraries with specific versions we rather want to add composer.lock instead.

[Slamdunk]

Ok, thanks to @gennadiylitvinyuk the main goals are achieved.
An initial cleanup is still missing tough.

[boesing]

@Slamdunk Features are not targeted against Patch releases. Maybe you accidentally added 2.14.1?

[Slamdunk]

To me, MINOR releases are for consumer features, not internal improvements ones.
#147 added zero consumer features, and zero internal improvements, btw.
Right now there are tons of static type bugs that we've drowned into psalm-baseline, and if and when someone have the willing to fix them, they'd go into a patch release, not a minor one, wdyt?

[Ocramius]

@Slamdunk if it's not a bugfix, it's already into the next minor: chore work is improvement, even if it has little impact downstream 💪

EDIT: to clarify further - only bugfixing in patches, nothing else. Keep patch releases as-stable-as-possible, including potential new artifacts, dev dependencies, etc.

[Slamdunk]

Ok then, sorry 🙏

[Fahl-Design]

Hi, pslam fails my fix for #162 ( #164 ) on 2.14.x because laminas-db is only suggested in laminas-validator package