-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks needed in snippet preview and <pre> blocks #1
Comments
Thanks! I'm unable to replicate the second issue you mentioned though. Mentions in blockquotes and code blocks are not wrapped in |
Here's what I'm seeing: Weirdly enough, |
Ah, alright. This is due to how I hackishly styled code blocks and blockquotes. Currently the entire blocks have filters applied to them which invert their colors and rotate the hue (this is why the Later today I'll definitely properly override these styles. This is easier with the newer Sass layout; my hackish filter method of doing this is a remnant from before. |
And the plot thickens with that last one. Mentions without a leading "@" look fine, slack must just be using a different span class for mentions with the leading "@". |
I noticed that but couldn't figure out what caused the difference--thanks! |
No prob! Just noticed this myself. |
The blocks contained within
div.snippet_preview
DIVs look like they still need some love.span.sssh-property
is still black-on-black.To reproduce, create a code snippet with Python highlighting and dump this code into it:
The "Timer" text will be invisible. This is similar to a fix you recently did for syntax highlighting, just needs to be made here as well.
Also,
pre.special_formatting
(triple-backtick-enclosed blocks of text) displays mentions (span.mention
) as grey-on-magenta.Thanks!
The text was updated successfully, but these errors were encountered: