Updating fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor visual alignment for FolderCover * Update change output
* Add callbacks for onDataReduced and onDataGrown * Add change file
* Basic truncated message bar variant * Removed comment * hasOverflow implemented, still need to resolve conflict with DelayedRender * Refactored naming for consistency and changing text overflow on click. Reinstating truncated prop. * More case consistency * Updated examples * Added tests * Revised example text * New class for mobile to expand instead of wrap * Added change file * Updating dismiss icon to Clear icon per toolkit * Change dismiss and expand icon color
* ExpandingCard fix for null content ref * Change file * Update magellan-fix_hovercard_2017-12-22-19-38.json * Update magellan-fix_hovercard_2017-12-22-19-38.json
* fix colors * change file * deprecate slots correctly
* Left nav scroll works, but not with uhf * Attached left nav and resizing on scroll * _handleNavPositioning for scroll and resize both * Wrapped Nav in FocusZone for arrow key nav instead of tab * Focus Zone for page header * Removed isNavOpen concept and other clean up * More isNavOpen cleanup * Revert "More isNavOpen cleanup" This reverts commit d8ac7de. * Revert "Removed isNavOpen concept and other clean up" This reverts commit ed823f6. * Removed isNavOpen state, no longer needed since mobile nav is gone * Nav position fixed and float left, more comments, adjusted scroll thresh * AttachScroll refactor, some app content refactor * App content refactor for header * Removed height variable, using state * Fixes jittery scroll in edge, attached header in ie, and small refactors * Max-width to make IE happy * IE top:unset fix * Removed console.log * Added change file * Adding width back in * Fixed test env edge case * Removed unused variables
… correctly (#3606) * fix card dismiss issue for hover card * add rush change file
* Enabling back text selection inside focusTrapZone * Changefile
* adding typings signatures in _onValidateInput() (cherry picked from commit 6e64def) * updated convertSuggestionsToSuggestionItems to handle both ISuggestionModel<T> and T (cherry picked from commit 9a8dd46) * added change file (cherry picked from commit 2abe508) * updated changes file to correct comment and email * first fix of accidental formatting to better show actual changes * added bind to SuggestionsController's private methods * formatting.1 of basePicker * formatting.2 of basePicker * formatting.3 of basePicker * formatting.4 of basePicker * changed to use autobind in Suggestions Controller * removed unnecessary inline typing of inferable type. * removed unnecessary parens.
* Searchbox and textfield neutral secondary placeholder text * Using the palette * Added change file * New slot for inputPlaceholderText * Semantic slots in styles * style change file * Minor bump * Searchbox snapshot update
* Removed astrisk and aligning font to text field * Better error border states * New Error example and example scss clean up * Added change file * Text field focused and invalid border fix * Better ComboBox error message borders * Update dropdown-errormessage_2018-01-22-18-50.json
* In Panel component, allow user to override all focus zone props. * Adding change file * Deprecate props rather than remove them completely. * Fixing comment. * If className is passed in focus trap zone props, ensure it is added alongside other class names provided to component. * Adding warnings about deprecations.
* Add divProps to ResizeGroup * rush change
* Fix week numbers column overlap with first column of calendar datepicker in RTL mode * Adding change file
…ed languages (#3713) * enable the base auto fill to work with composed languages like Japanese. Also made some small improvements to structure * adding change file * removing unecessary import * fix lint * Update BasePicker Snap * Fixing comments and minor bug in firefox * Make onchange better and update snaps * adding in comments * fixing comments * small code cleanup
* [SearchBox] onChange and flex layout fix for IE * [SearchBox] Use flex shorthand
…us border when focused by keyboard (#3774) * added onFocus to BasePicker state and added a control class to input container & Updated Snapshot and Rush Changelog
* Null out timeouts * Change file * Tweaks * Lint
* Fixing broken links. * rush change
* Making picker suggestions callout align to correct rtl position * rush change * Removing getRTL import
* add header element, fix css styling for items and input * add change file * fix tslint errors
… buttons (#3780) * removed spin button aria-hiddne property * updated spin button test to no longer need aria-hidden * added accessibiltiy labels for spin buttons increment/decrement buttons * added change file
Fixes a minor docs bug with the `@uifabric/styling` README. `colors` should instead be `palette`. See the value of the object returned from `createTheme` [here](https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/styling/src/styles/theme.ts#L107) for an example of what I mean.
* Add base callout file * Rename file to CalloutContent.base * CalloutContentbase * Callout content styling * Callout content styling * Add hostid * Revert "Add hostid" This reverts commit d5a842d. * Animation styles * Refactor base callout content to use js styling * Create calloutContent const * Fix import * Styling changes * FIx beak background styling and boxShadow * Fix callout width * Add inline styling from popup * Remove callout.scss file * Add change file * Update snapshot and maxheight and masfontsize to CSSPixelUnitRule * Add focus clear mixin to styling package an use it * Add remaining change files * Add base callout file * Rename file to CalloutContent.base * CalloutContentbase * Callout content styling * Callout content styling * Animation styles * Refactor base callout content to use js styling * Create calloutContent const * Fix import * Styling changes * FIx beak background styling and boxShadow * Fix callout width * Add inline styling from popup * Remove callout.scss file * Add change file * Update snapshot and maxheight and masfontsize to CSSPixelUnitRule * Add focus clear mixin to styling package an use it * Add remaining change files * Add comments * Add comment for beak style * Test using CalloutContent * Use spread operator
* setting people picker coin default back to 28 from 24 * change note
* new line * Updating icons * rush change file * Removing the third party logos from the list of icons being exported * Updating the names of enum, not to start with a number
* Add overflow menu props to CommandBar * Add change file
* Add private _defaultCalloutProps instead of public defaultProps to set calloutProps. * npm run change output * Re-add public static defaultProps but deprecate the calloutProps, and then spread the default calloutProps and the _defaultCalloutProps into a new object that's passed into Callout.
onRenderCoin prop that controls the image coin - with example
* Fix the callout having an overflow when it shouldn't * Minor fixes
* adding new work week date range type * adding the work week type, adding the highlighting and selecting logic of work week, adding date range selection unit test for DateMath for work week * adding npm change files, updating default for the datemath utility * changing selectableDaysOfWeek to workWeekDays, adding comment noting that the property does nothing if not in WorkWeek view
* Pass onDismiss to Callout component. * npm run change output
…false" (#3831) Added prop to ComboBox to control its button's aria-hidden attribute
* Update the way the comboBox expands to not autoexpand for allowfreeform (but it should stay expanded if it is already open) * rush change
* Fixing the up and down arrows position and behavior * Adding change file
* make selection optional, change render to any * npm change * add override for recieved props
…g to the correct element (#3838) * Contextual Menus should not contain a list and the aria-label/labelledby should be on the menu * rush change
* added aria-label support for the swatch color picker * removed aria label for cells * added aria comment; added change files * updated test snap file * added native props spread operators instead of defining aria attributes to be more generic * remove inheriting the onblur prop in the wrong location * added the aria-set attributes back in and excluded the native ones the user might add in * reverted test * updated to just pass in props to grid to parse
* fix whitespace wrapping with prefix/suffix * change file * Update prefix-suffix-whitespace_2018-01-30-21-56.json
* Adjusted css to wrap text and not cut off descenders * Edited example to show wrapping text * Added change file * Gave the field height and width so that it doesn't stretch past its box * Updated story to include text wrappingd * Image height test * Text margin fix * Border test
removed unused scss file from Sticky component
…essary validation failures (#3843) * direct comparison of objects returns false, need to stringify to compare * adding change file * build didn't like ==, changing to === * final fixes
* Add isControlled flag that enables/disables onInput and onChange so TextFields with a value prop can't be edited by users, use defaultValue instead (BREAKING CHANGE). * Update docs to clarify usage of value and defaultValue. * Add examples using value and defaultValue * Remove redundant check on _isControlled flag. * Clarify examples * npm run change output * Add readOnly to non-editable example fields. * Trying: Add readOnly to input/textarea if _isControlled is false instead of requiring it on the TextField component props to pass jest. * Change NumberTextField value to defaultValue * DatePicker use defaultValue instead of value on TextField * Error examples use defaultValue instead of Value. * TextField tests to use defaultValue instead of value. * Update snapshots.
* new line * Updating icons * rush change file * Removing the third party logos from the list of icons being exported * Updating the names of enum, not to start with a number * Adding new WOFF files to the @uifabric/icons/fonts folder
* Fix bug in modal selection handling * Update change output * Fix touch handling for modal selection * Update snapshot output
…-color is not set for page (#3833) Added return default when reaching the html tag in while loop inside _getBackground() inside Sticky component and added color prop that falls back to getBackground function, and added Sticky to ScrollablePane's property table
* new line * updating config files * rush change file
kysedate
pushed a commit
that referenced
this pull request
Mar 15, 2018
…b font (microsoft#4206) * By default, use the system segoe-ui * Fix it more consistently * Rush change * Snapshot updates * Make it work for IE and Edge as well. * Update snapshots * Add some snapshots for the before state of createFontStyles * Refactor #1 * Update default font styles * Another refactor * Remove unused import * Update snapshot
kysedate
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Mv Slider implementation to .base.tsx * Export Slider.base * Slider impl with getStyles and interface imports * Refactor hierarchy to Slider.styles and expose via interfaces * Reflect current set of style attrs and globals * + changefile * Update Slider snapshot test * Refactor Slider tests to test SliderBase * Add SliderBase type param throughout Slider tests * Test Slider for snapshot comparison only * Minor typing fix per PR feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
(give an overview)
Focus areas to test
(optional)