Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dismissal buttons to our notifications #3605

Open
johncowen opened this issue Feb 26, 2025 · 1 comment
Open

add dismissal buttons to our notifications #3605

johncowen opened this issue Feb 26, 2025 · 1 comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@johncowen
Copy link
Contributor

Description

Follow up of #3566

We need the dismissal actions to not only track when you have dismissed a notification and store that, but also remove that storage once the logic that showed the notification is reversed.

We also want to "garbage collect" the local storage values every-so-often so notifications appear again after say 7 days (you'd have to dismiss again, or actually sort out the issue to prevent it appearing again)

@johncowen johncowen added kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting labels Feb 26, 2025
@johncowen johncowen added this to the 2.10.x milestone Feb 26, 2025
@johncowen johncowen self-assigned this Feb 26, 2025
@johncowen
Copy link
Contributor Author

This is milestone-d 2.10.x for now, but may slip

@lahabana lahabana modified the milestones: 2.10.x, 2.11.x Mar 3, 2025
@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

3 participants