Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend unused variables lint rule to allow us to not have to prefix function arguments with _ #3602

Open
johncowen opened this issue Feb 26, 2025 · 1 comment
Open

Amend unused variables lint rule to allow us to not have to prefix function arguments with _ #3602

johncowen opened this issue Feb 26, 2025 · 1 comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@johncowen
Copy link
Contributor

Description

Leaving function arguments in can sometimes help documentation/discovery.

If there are no other side-effects from configuring this rule to allow unused function arguments then we should configure the rule to allow us.

Note: I do remember that uglify used to remove unused arguments form the final compiled source, not sure what happens nowadays, would be good to check the compiled source whilst looking at this.
@johncowen johncowen added kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting labels Feb 26, 2025
@johncowen johncowen mentioned this issue Feb 27, 2025
Merged
@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 3, 2025
@lahabana
Copy link
Contributor

Isn't keep _unused_param a fairly common coding practice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johncowen @lahabana @bartsmykla