Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate list of badges in About Sections #3352

Open
schogges opened this issue Jan 6, 2025 · 4 comments
Open

Truncate list of badges in About Sections #3352

schogges opened this issue Jan 6, 2025 · 4 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@schogges
Copy link
Contributor

schogges commented Jan 6, 2025

Description

Follow up to #3300

Next to the adoption of the AppAboutSection component, we started to use badges for the information displayed in the About Section card. Some of them show list of badges. In order to improve the layout and reduce the noise in these cards we should consider to truncate these lists.

Some of the lists use the TagList component that can be optionally truncated. The default is currently set to false. We should consider to set default to true.
In other cases we create these lists inline and use XBadge or other components (e.g. KumaPort) directly. We should consider to align this (if possible) and maybe always use TagList.

Context/Examples

No Truncation

Screenshot 2025-01-06 at 11 14 46
Screenshot 2025-01-06 at 11 14 59

Truncation

Screenshot 2025-01-06 at 11 30 34
Screenshot 2025-01-06 at 11 30 44

@schogges schogges added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Jan 6, 2025
@johncowen
Copy link
Contributor

There's possibly some decision written somewhere on this that we said we would always use expanded (non-truncated) badges in summaries and details pages. i.e. we would only use truncations in lists.

Thinking being: You've already clicked to see the detail, so show me all the detail, don't make me click more things again to see the detail I want to see.

Let me see if I can find anything in a previous PR, but we can also chat more if opinions have changed.

@johncowen
Copy link
Contributor

Ah I forgot that I think we spoke about this before the break, ignore my previous comment!

@schogges
Copy link
Contributor Author

schogges commented Jan 6, 2025

xref to #3333 to basically consider using XLayout with truncate for this

@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 6, 2025
@lobkovilya
Copy link
Contributor

Triage: let's check what Konnect is doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

3 participants