From 71db4fc80e8a8e01a9f4140435046f4d10906f61 Mon Sep 17 00:00:00 2001 From: sharego Date: Sat, 30 Nov 2019 15:24:04 +0800 Subject: [PATCH 1/2] Fix kubectl-kudo flag conflict #1120 --- pkg/kudoctl/cmd/package_params_list.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kudoctl/cmd/package_params_list.go b/pkg/kudoctl/cmd/package_params_list.go index 7c977a86f..26e86e0a6 100644 --- a/pkg/kudoctl/cmd/package_params_list.go +++ b/pkg/kudoctl/cmd/package_params_list.go @@ -56,7 +56,7 @@ func newParamsListCmd(fs afero.Fs, out io.Writer) *cobra.Command { f.BoolVarP(&list.requiredOnly, "required", "r", false, "Show only parameters which have no defaults but are required.") f.BoolVar(&list.namesOnly, "names", false, "Display only names.") f.StringVar(&list.RepoName, "repo", "", "Name of repository configuration to use. (default defined by context)") - f.StringVarP(&list.PackageVersion, "version", "v", "", "A specific package version on the official GitHub repo. (default to the most recent)") + f.StringVarP(&list.PackageVersion, "version", "", "", "A specific package version on the official GitHub repo. (default to the most recent)") return cmd } From 5eecfdd7c40251d2139e842e7c16512ff988bc1f Mon Sep 17 00:00:00 2001 From: sharego Date: Mon, 2 Dec 2019 20:22:28 +0800 Subject: [PATCH 2/2] Remove cli package params list version short hand flag `-v` --- pkg/kudoctl/cmd/package_params_list.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kudoctl/cmd/package_params_list.go b/pkg/kudoctl/cmd/package_params_list.go index 26e86e0a6..d9eafbe65 100644 --- a/pkg/kudoctl/cmd/package_params_list.go +++ b/pkg/kudoctl/cmd/package_params_list.go @@ -56,7 +56,7 @@ func newParamsListCmd(fs afero.Fs, out io.Writer) *cobra.Command { f.BoolVarP(&list.requiredOnly, "required", "r", false, "Show only parameters which have no defaults but are required.") f.BoolVar(&list.namesOnly, "names", false, "Display only names.") f.StringVar(&list.RepoName, "repo", "", "Name of repository configuration to use. (default defined by context)") - f.StringVarP(&list.PackageVersion, "version", "", "", "A specific package version on the official GitHub repo. (default to the most recent)") + f.StringVar(&list.PackageVersion, "version", "", "A specific package version on the official GitHub repo. (default to the most recent)") return cmd }