Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizable distroless image and builder image for go-runner #2702

Closed
jeremyrickard opened this issue Oct 10, 2022 · 2 comments · Fixed by #2709
Closed

Allow customizable distroless image and builder image for go-runner #2702

jeremyrickard opened this issue Oct 10, 2022 · 2 comments · Fixed by #2709
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@jeremyrickard
Copy link
Contributor

What would you like to be added:

The ability to override the builder image used in the go-runner Dockerfile, along with fully specifying the DISTROLESS_IMAGE.

Why is this needed:

The current Dockerfile and Makefile support specifying a specific distroless image to use, but the registry is not part of that customizability (i.e. it always points to gcr.io). We'd like to be able to fully specify where the distroless image comes from so that we can build go-runner images for our use, that are based on those distroless images we are producing. Additionally, we'd like to be able to fully specify the builder image so utilize our custom Go builder image.

I have a PR that I believe does this (and updates the cloudbuild.yaml and variants.yaml files to fully specify the registry+repo for the distroless images.

@jeremyrickard jeremyrickard added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Oct 10, 2022
@saschagrunert
Copy link
Member

Sounds like a reasonable enhancement to me. Do you plan to work on this topic as well @jeremyrickard ?

@jeremyrickard
Copy link
Contributor Author

@saschagrunert sure thing! I’ll propose a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants