Mismatched or dirty local k/release copy does not block krel gcbmgr runs

[justaugustus]

What happened:

The repo state check in #1254 does not appear to block gcbmgr runs with a dirty or out of sync local copy of k/release.

/assign @saschagrunert

[saschagrunert]

Yes, my template for the implementation was this function, which do not check those cases as well:

release/lib/gitlib.sh

Lines 296 to 328 in 61c2711

	gitlib::repo_state () {
	local expectedOrg="${TOOL_ORG:-kubernetes}"
	local expectedRepo="${TOOL_REPO:-release}"
	local expectedRemote="[:/]${expectedOrg}/${expectedRepo}"
	local expectedBranch="${TOOL_BRANCH:-master}"
	local branch
	branch=$(gitlib::current_branch "$TOOL_ROOT") || return 1
	if [ "${expectedBranch}" != "$branch" ]
	then
	logecho "$FAILED checked out branch $branch is not the same as $expectedBranch"
	return 1
	fi
	local remotePattern="${expectedRemote}(.git)* \(fetch\)$"
	local remote=$( git -C "$TOOL_ROOT" remote -v | grep -E "$remotePattern" -m 1 | cut -f1 )
	local commit=$(git -C "$TOOL_ROOT" \
	ls-remote --heads "$remote" refs/heads/master | cut -f1)
	local output=$(git -C "$TOOL_ROOT" branch --contains "$commit" "$branch" 2>/dev/null)
	logecho -n "Checking $TOOL_ROOT state: "
	if [[ -n "$output" ]]; then
	logecho $OK
	else
	logecho "$FAILED"
	logecho
	logecho "$TOOL_ROOT is not up to date."
	logecho "$ git pull"
	return 1
	fi
	}

So we can add two possible checks:

• Error if the repository is dirty
• Error if the current commit does not match exactly the latest remote commit

In case of the second error path the branch --contains check could be replaces with a basic SHA comparison. WDYT? Should we add both?

[justaugustus]

@saschagrunert -- Let's aim to check for both. The shell-based gcbmgr did check for the latter.

[saschagrunert]

Fix is incoming in #1284