Cannot disable default storage class

[olivierlemasle]

Steps to reproduce:

1. Start minikube (from scratch)
2. Disable addon :

   > minikube addons disable default-storageclass
   ✅  "default-storageclass" was successfully disabled
   

3. List storage classes:

   > kubectl get storageclasses.storage.k8s.io 
   NAME                 PROVISIONER                AGE
   standard (default)   k8s.io/minikube-hostpath   4m14s
   

Bug: standard storage class is still marked as default.

Actually, the storage class is then annotated with both storageclass.kubernetes.io/is-default-class: "true" (from the addon) and storageclass.beta.kubernetes.io/is-default-class: "false" (added with minikube addons disable default-storageclass):

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    storageclass.beta.kubernetes.io/is-default-class: "false"
    storageclass.kubernetes.io/is-default-class: "true"
  creationTimestamp: "2019-11-20T12:40:29Z"
  labels:
    addonmanager.kubernetes.io/mode: EnsureExists
  name: standard
  resourceVersion: "600"
  selfLink: /apis/storage.k8s.io/v1/storageclasses/standard
  uid: cdef4691-5dc5-42c5-8e02-db45e4b4265c
provisioner: k8s.io/minikube-hostpath
reclaimPolicy: Delete
volumeBindingMode: Immediate

Minikube version: v1.5.2

Kubernetes version: v1.16.2

[tstromberg]

Nice catch! Thank you for sending us a PR to address this.