crio.conf is hard-coded to a specific version

[afbjorklund]

The contents of /etc/crio/crio.conf is very context-sensitive to a particular version of cri-o:

https://github.com/kubernetes/minikube/commits/master/deploy/iso/minikube-iso/package/crio-bin/crio.conf.default

Yet we are overwriting the whole thing with a static template, even if only changing pause_image.

pause_image = "{{ .PodInfraContainerImage }}"

This breaks things, when there is a mismatch between minikube and minikube.iso (or other OS)

We should either make a smaller configuration change, or version the config file accordingly.

It also seem to be located in the wrong module, it's in (the generic) CRI rather than in CRI-O ?

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/cruntime/cri.go#L34_L328

I tried to use crio on a platform with crio 1.13, and it blew up.

The new configuration made it unable to find the "seccomp.json"

[afbjorklund]

There is also other things missing, from the systemd crio.service: #4087

So the crio.conf, /etc/sysconfig/crio* and crio*.service all need overhaul

[afbjorklund]

I will replace the overwrite, with some kind of more specific config update instead of the clobber:

	c := exec.Command("/bin/bash", "-c", fmt.Sprintf("sudo mkdir -p %s && printf %%s \"%s\" | base64 -d | sudo tee %s", path.Dir(cPath), base64.StdEncoding.EncodeToString(b.Bytes()), cPath))

Would be nice if we could edit this TOML, with having to include all of the cri-o code to do it ?

# The image used to instantiate infra containers.
# This option supports live configuration reload.
pause_image = "{{ .PodInfraContainerImage }}"

[afbjorklund]

I went with sed (instead of previous tee)