Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none: minikube delete should call kubeadm reset #3637

Closed
tstromberg opened this issue Feb 7, 2019 · 2 comments
Closed

none: minikube delete should call kubeadm reset #3637

tstromberg opened this issue Feb 7, 2019 · 2 comments
Labels
co/none-driver good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@tstromberg
Copy link
Contributor

This would allow the none driver to mostly clean up after itself.

@afbjorklund
Copy link
Collaborator

Sounds like a good idea! For some reason, that API is missing from the bootstrapper...

It goes straight for DeleteHost, which of course is rather useless without any host.

func (d *Driver) Remove() error {
        return nil
}

Any good idea, what rhymes with StartCluster (and where StopCluster is misleading) ?

Maybe DeleteCluster ? That way it would match StartHost/DeleteHost for naming.

@tstromberg
Copy link
Contributor Author

DeleteCluster sounds good to me.

@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. co/none-driver kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/none-driver good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants