Running with containerd starts crio

[afbjorklund]

This looks broken:

minikube start --no-kubernetes --vm --container-runtime=containerd

🏄 Done! minikube is ready without Kubernetes!

$ minikube ssh -- pstree
systemd-+-acpid
        |-2*[agetty]
        |-crio---11*[{crio}]
        |-dbus-daemon
        |-rpc.mountd
        |-rpc.statd
        |-rpcbind
        |-sshd---sshd---sshd---pstree
        |-systemd-hostnam
        |-systemd-journal
        |-systemd-logind
        |-systemd-network
        |-systemd-resolve
        |-systemd-timesyn---{systemd-timesyn}
        `-systemd-udevd---20*[systemd-udevd]

---

It was supposed to run containerd, not crio ?

$ minikube ssh -- sudo ctr version
Client:
  Version:  v1.4.12
  Revision: 7b11cfaabd73bb80907dd23182b9347b4245eb5d
  Go version: go1.17

ctr: failed to dial "/run/containerd/containerd.sock": context deadline exceeded
ssh: Process exited with status 1

When running with docker, it would start both.

(This is because CRI-O is started on boot of VM)

[MdSahil-oss]

/assign

[afbjorklund]

It is missing a call to configureRuntimes, before the configureMounts (and return):

        stopk8s, err := handleNoKubernetes(starter)
        if err != nil {
                return nil, err
        }
        if stopk8s {
                configureMounts(&wg, *starter.Cfg)
                return nil, config.Write(viper.GetString(config.ProfileName), starter.Cfg)
        }