Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ClusterConfig does not store the addons map #10564

Closed
medyagh opened this issue Feb 22, 2021 · 6 comments
Closed

refactor: ClusterConfig does not store the addons map #10564

medyagh opened this issue Feb 22, 2021 · 6 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@medyagh
Copy link
Member

medyagh commented Feb 22, 2021

while doing this PR #10427
I noticed the addons is not saved in config when I need it

// ControlPlaneEndpoint returns the location where callers can reach this cluster
func ControlPlaneEndpoint(cc *config.ClusterConfig, cp *config.Node, driverName string) (string, net.IP, int, error) {
	if cc.Addons["auto-pause"] { // <---HERE IT IS it is empty map
		fmt.Println("auto-ause is on so cp port is", constants.AutoPauseProxyPort)
		cp.Port = constants.AutoPauseProxyPort
	}

 &{Name:minikube KeepContext:false EmbedCerts:false MinikubeISO: KicBaseImage:gcr.io/k8s-minikube/kicbase-builds:v0.0.17-1613861585-10427@sha256:c0827e1b58f31cbfeb871af9c7656e5822bd97dd0011b9edd45ddd1ee9ef9dfd Memory:4000 CPUs:2 DiskSize:20000 VMDriver: Driver:docker HyperkitVpnKitSock: HyperkitVSockPorts:[] DockerEnv:[] ContainerVolumeMounts:[] InsecureRegistry:[] RegistryMirror:[] HostOnlyCIDR:192.168.99.1/24 HypervVirtualSwitch: HypervUseExternalSwitch:false HypervExternalAdapter: KVMNetwork:default KVMQemuURI:qemu:///system KVMGPU:false KVMHidden:false DockerOpt:[] DisableDriverMounts:false NFSShare:[] NFSSharesRoot:/nfsshares UUID: NoVTXCheck:false DNSProxy:false HostDNSResolver:true HostOnlyNicType:virtio NatNicType:virtio SSHIPAddress: SSHUser:root SSHKey: SSHPort:22 KubernetesConfig:{KubernetesVersion:v1.20.2 ClusterName:minikube Namespace:default APIServerName:minikubeCA APIServerNames:[] APIServerIPs:[] DNSDomain:cluster.local ContainerRuntime:docker CRISocket: NetworkPlugin: FeatureGates: ServiceCIDR:10.96.0.0/12 ImageRepository: LoadBalancerStartIP: LoadBalancerEndIP: CustomIngressCert: ExtraOptions:[] ShouldLoadCachedImages:true EnableDefaultCNI:false CNI: NodeIP: NodePort:8443 NodeName:} Nodes:[{Name: IP:192.168.49.2 Port:8443 KubernetesVersion:v1.20.2 ControlPlane:true Worker:true}] Addons:map[] VerifyComponents:map[apiserver:true system_pods:true] StartHostTimeout:6m0s ScheduledStop:<nil> ExposedPorts:[] Network: MultiNodeRequested:false}todomedya: 127.0.0.1 55102 /Users/medya/.kube/config
@BLasan
Copy link
Contributor

BLasan commented Feb 22, 2021

@medyagh Shall I give a try to fix this?

@medyagh medyagh added this to the v.1.19.0-candidate milestone Feb 22, 2021
@medyagh medyagh added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 22, 2021
@medyagh
Copy link
Member Author

medyagh commented Feb 22, 2021

sure ! @BLasan it is yours

@BLasan
Copy link
Contributor

BLasan commented Feb 23, 2021

sure ! @BLasan it is yours

Thanks sir

@medyagh medyagh changed the title ClusterConfig does not store the addons map refactor: ClusterConfig does not store the addons map Mar 1, 2021
@BLasan
Copy link
Contributor

BLasan commented Mar 12, 2021

@medyagh I tried this by storing configurations in start.go. Seems to be not working as expected. This particular function is associated with minikube status command right?

@tharun208
Copy link
Contributor

@medyagh with the latest master, I am able to see addons are getting saved in config ( both default and those enabled at run-time)

Screen Shot 2021-03-31 at 1 24 59 PM

@medyagh medyagh modified the milestones: v1.20.0, v1.21.0-candidate May 3, 2021
@sharifelgamal sharifelgamal added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 3, 2021
@medyagh medyagh modified the milestones: v1.21.0, 1.22.0-candidate May 3, 2021
@andriyDev
Copy link
Contributor

As far as I can tell this is no longer an issue. Thank you @tharun208!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants