Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import tool dependencies in go modules instead of go get #918

Closed
tariq1890 opened this issue Oct 1, 2019 · 2 comments · Fixed by #927
Closed

Import tool dependencies in go modules instead of go get #918

tariq1890 opened this issue Oct 1, 2019 · 2 comments · Fixed by #927
Labels
hacktoberfest help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tariq1890
Copy link
Contributor

As per the best practices recommended by the Go team, it is better to add tool dependencies like embedmd, benchcmp etc as module dependencies instead of go get as done over here.

You can follow the steps mentioned here: https://github.com/kubernetes/kube-state-metrics/blob/master/Makefile#L136
@tariq1890 tariq1890 added hacktoberfest help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 1, 2019
@jeremyklein
Copy link

I can give this a shot!

@tariq1890
Copy link
Contributor Author

Please do :)

@jukie jukie mentioned this issue Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tools as go modules
2 participants
@tariq1890 @jeremyklein