Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase the image to distroless #1787

Closed
yuwenma opened this issue Mar 12, 2019 · 4 comments
Closed

Rebase the image to distroless #1787

yuwenma opened this issue Mar 12, 2019 · 4 comments
Assignees

Comments

@yuwenma
Copy link
Contributor

yuwenma commented Mar 12, 2019

We are currently working on rebasing k8s base images to distroless. Distroless image has several good features (smaller in size, fewer components requiring CVE patching, etc) but also doesn't have some dependencies autoscaler uses (shell). To use distroless as the base image, the following AIs needs to be done:
Step 1. Sync up with current k8s head.
Reason: oss kubernetes no longer uses glog which requires shell to redirect the log file. Instead, k8s is using klog which accepts a log path flag. This sync-up is necessary to remove the bash file run.sh which is used to redirect the glog.
Step 2. Replace the glog to klog in other autoscaler files.
Step 3. Update the base image to distroless and remove distroless-preinstalled packages like ca-certificate.
Step 4. After the above steps are done, require release engineers' help on monitoring the performance.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 12, 2019
@warmchang
Copy link

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 17, 2019
@losipiuk
Copy link
Contributor

Done. CA 1.16.0 is based on distroless image. (https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.16.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants