Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect version number is shown #123

Closed
marquiz opened this issue Feb 16, 2022 · 1 comment · Fixed by #131
Closed

Incorrect version number is shown #123

marquiz opened this issue Feb 16, 2022 · 1 comment · Fixed by #131
Assignees
@thiagompc
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@marquiz
Copy link
Contributor

marquiz commented Feb 16, 2022

What happened:

-version flag doesn't work as expected

What you expected to happen:

It shows the correct version.

How to reproduce it (as minimally and precisely as possible):

$ make build
$ ./node-feature-discovery-operator -version
nfd-operator v0.0.0-master+$Format:%H$

Anything else we need to know?:

We have version/version.go that is unused afaiu
@marquiz marquiz added the kind/bug Categorizes issue or PR as related to a bug. label Feb 16, 2022
@ArangoGutierrez ArangoGutierrez added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 16, 2022
@thiagompc
Copy link

/assign

@ArangoGutierrez ArangoGutierrez mentioned this issue Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiagompc thiagompc

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable --version flag ArangoGutierrez/node-feature-discovery-operator
3 participants
@marquiz @ArangoGutierrez @thiagompc