Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace https://github.com/google/shlex with https://github.com/carapace-sh/carapace-shlex #5842

Closed
dims opened this issue Jan 15, 2025 · 3 comments · Fixed by #5847
Closed

Replace https://github.com/google/shlex with https://github.com/carapace-sh/carapace-shlex #5842

dims opened this issue Jan 15, 2025 · 3 comments · Fixed by #5847
Assignees
@koba1t
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@dims
Copy link
Member

dims commented Jan 15, 2025

Related to kubernetes/kubernetes#120276

shlex has been archived since Dec 29, 2022. carapace-shlex is an active fork. Can we please switch to it?
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 15, 2025
@dims dims mentioned this issue Jan 15, 2025
Open
@koba1t
Copy link
Member

koba1t commented Jan 15, 2025

/assign

@koba1t koba1t mentioned this issue Jan 16, 2025
Merged
@koba1t
Copy link
Member

koba1t commented Jan 17, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 17, 2025
@koba1t
Copy link
Member

koba1t commented Jan 17, 2025

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koba1t koba1t

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@dims @k8s-ci-robot @koba1t