Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 #6053

Merged
merged 1 commit into from
May 6, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Apr 30, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update cni spec for network plugin that allow it

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
CNI plugin spec matrix :

  • macvlan is bundle with cni plugins 0.8.5 and support spec 0.4.0
  • Multus support 0.4.0
  • Cilum don't support 0.4.0, only 0.3.1
  • Calico/Flannel (and Canal) don't support 0.4.0, only 0.3.1
  • Contiv only support 0.3.1
  • Weave doesn't support 0.4.0 nor 0.3.1, only 0.3.0
  • Looks like kube-router only support 0.3.0

Also fix networking test error (if debug where executing on other instance than [0])

task path: /builds/kargo-ci/kubernetes-sigs-kubespray/tests/testcases/040_check-network-adv.yml:63
Sunday 03 May 2020 05:41:44 +0000 (0:00:00.073) 0:00:19.640 ************
ok: [instance-3] => {
"failed_when_result": false,
"nca_pod.stdout_lines": "VARIABLE IS NOT DEFINED!: 'dict object' has no attribute 'stdout_lines'"
}

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO April 30, 2020 15:44
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 30, 2020
@Miouge1 Miouge1 added this to the 2.14 milestone May 1, 2020
@floryut floryut force-pushed the update_cni_spec branch from 640bbc2 to 545557d Compare May 2, 2020 20:39
@floryut floryut changed the title WIP - Update cni spec to 0.4.0 available since cni plugins 0.8.0 WIP - Update cni spec to 0.4.0 (for cni allowing it) available since cni plugins 0.8.0 May 3, 2020
@floryut floryut changed the title WIP - Update cni spec to 0.4.0 (for cni allowing it) available since cni plugins 0.8.0 WIP - Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 May 3, 2020
@floryut floryut force-pushed the update_cni_spec branch 10 times, most recently from f0ca1e6 to 53271f2 Compare May 3, 2020 19:14
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2020
@floryut floryut changed the title WIP - Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 May 4, 2020
@floryut floryut marked this pull request as ready for review May 4, 2020 07:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2020
@floryut floryut changed the title Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 WIP - Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 May 4, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2020
@floryut floryut force-pushed the update_cni_spec branch from 53271f2 to c206467 Compare May 4, 2020 07:57
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2020
@EppO
Copy link
Contributor

EppO commented May 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2020
@EppO
Copy link
Contributor

EppO commented May 5, 2020

Weird, CNI spec 0.4.0 was released a year ago and very few CNI plugins support it.

@floryut
Copy link
Member Author

floryut commented May 5, 2020

Weird, CNI spec 0.4.0 was released a year ago and very few CNI plugins support it.

Yes I was hopeful before testing the matrix but in fact it's not that widespread at all :/

@floryut floryut changed the title WIP - Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 Update cni spec to 0.4.0 (for net plugins allowing it) available since cni plugins 0.8.0 May 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented May 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 965fe1d into kubernetes-sigs:master May 6, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants