-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard docker-image #2401
Comments
This feature seems a little bit overfit for your particular image naming. I haven't seen many (any?) examples of images with partial naming matches and identical tags that should be simultaneously loaded. We support essentially the same input as "docker save" and I'm not sure we should be different from that. Tools like skaffold and tilt are also expecting to use this command in kind and other cluster tools and I'm not aware of any other tools having special characters in the input. |
I hear you. However docker save is a purpose built command to save 1 image. I cant think of a case where you would want to use docker save for multiple images. The command is inherently linked to 1 image. Whereas kind, at least in my view, should support loading multiple images at once. I do see
I agree there isn't really a case where a "product" ships multiple images but there is a case when working locally on projects that aren't just 1 "product" and the images are all named by domain. In my previous example you could have
instead of
If you're worried about breaking changes another option is to add the |
That's not the case, it does support multiple in docker. The command is When you save multiple images together you get a single tarball you can ship around that contains multiple docker images with the shared layers deduped.
It doesn't really make sense to load all tags for an image? This seems like a pretty unlikely development flow.
We're hoping instead to make future image loading compatible with podman as that node backend matures #2038 If you want to do docker images --filter you can do: |
I don't think we want to pursue this versus unifying with podman. |
What would you like to be added:
The ability to wildcard
kind load docker-image
. For examplekind load docker-image MyProject*:1.0.0
would loadMyProjectFrontend:1.0.0
andMyProjectBackend:1.0.0
Why is this needed:
To simplify cluster creation. Every now and again to ensure that clean setup still works I delete the cluster and recreate it. Then have to macro a
docker image list
in vscode so that I can load all the images into the new cluster with multiple commands. It would be great if we can utilise wildcards to simplify this directly with kind instead of having to write scripts or manually macro the list out.Linking #1905 since I got there from googling how to do the above
The text was updated successfully, but these errors were encountered: