Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restmapper: Use aggregated discovery if available #2897

Closed
alvaroaleman opened this issue Jul 31, 2024 · 1 comment · Fixed by #2901
Closed

Restmapper: Use aggregated discovery if available #2897

alvaroaleman opened this issue Jul 31, 2024 · 1 comment · Fixed by #2901
Assignees
@alvaroaleman
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@alvaroaleman
Copy link
Member

We've built a lazy restmapper that only fetches mappings when needed to reduce the number of api calls made and thus speed things up. In the meantime, upstream built aggregated discovery which allows to fetch all restmappings with a single api call.

We should update our restmapper to use aggregated discovery if available.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2024
@sbueringer sbueringer added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 1, 2024
@sbueringer
Copy link
Member

Sounds good!

@alvaroaleman alvaroaleman self-assigned this Aug 3, 2024
@alvaroaleman alvaroaleman mentioned this issue Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvaroaleman alvaroaleman

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Use aggregated discovery if available alvaroaleman/controller-runtime
3 participants
@sbueringer @alvaroaleman @k8s-ci-robot