From e2440a5d847dd3fd4afd429b109242f3b2580f5a Mon Sep 17 00:00:00 2001 From: Tsuzu <8574909+tsuzu@users.noreply.github.com> Date: Wed, 7 Aug 2024 03:32:24 +0900 Subject: [PATCH] Log error when Lifecycle Hook Runtime Extension returns an error --- internal/runtime/client/client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/runtime/client/client.go b/internal/runtime/client/client.go index 1d9f2b3dc63e..78ea98c63d07 100644 --- a/internal/runtime/client/client.go +++ b/internal/runtime/client/client.go @@ -346,7 +346,7 @@ func (c *client) CallExtension(ctx context.Context, hook runtimecatalog.Hook, fo ignore := *registration.FailurePolicy == runtimev1.FailurePolicyIgnore if _, ok := err.(errCallingExtensionHandler); ok && ignore { // Update the response to a default success response and return. - log.Info(fmt.Sprintf("ignoring error calling extension handler because of FailurePolicy %q", *registration.FailurePolicy)) + log.Error(err, fmt.Sprintf("ignoring error calling extension handler because of FailurePolicy %q", *registration.FailurePolicy)) response.SetStatus(runtimehooksv1.ResponseStatusSuccess) response.SetMessage("") return nil