From 8a5654929f98e43650b4613a0a433384c7a65247 Mon Sep 17 00:00:00 2001 From: Amim Knabben Date: Tue, 3 Jan 2023 16:31:58 -0300 Subject: [PATCH] Removing deprecated --list-images flag on init command --- cmd/clusterctl/cmd/init.go | 18 ------------------ .../src/developer/providers/v1.3-to-v1.4.md | 1 + 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/cmd/clusterctl/cmd/init.go b/cmd/clusterctl/cmd/init.go index 3681905beb3c..9d6eafbdbf9d 100644 --- a/cmd/clusterctl/cmd/init.go +++ b/cmd/clusterctl/cmd/init.go @@ -17,7 +17,6 @@ limitations under the License. package cmd import ( - "fmt" "time" "github.com/spf13/cobra" @@ -35,7 +34,6 @@ type initOptions struct { ipamProviders []string runtimeExtensionProviders []string targetNamespace string - listImages bool validate bool waitProviders bool waitProviderTimeout int @@ -114,10 +112,6 @@ func init() { initCmd.Flags().BoolVar(&initOpts.validate, "validate", true, "If true, clusterctl will validate that the deployments will succeed on the management cluster.") - initCmd.Flags().BoolVar(&initOpts.listImages, "list-images", false, - "Lists the container images required for initializing the management cluster (without actually installing the providers)") - _ = initCmd.Flags().MarkDeprecated("list-images", "use 'clusterctl init list-images' instead.") - initCmd.AddCommand(initListImagesCmd) RootCmd.AddCommand(initCmd) } @@ -143,18 +137,6 @@ func runInit() error { IgnoreValidationErrors: !initOpts.validate, } - if initOpts.listImages { - images, err := c.InitImages(options) - if err != nil { - return err - } - - for _, i := range images { - fmt.Println(i) - } - return nil - } - if _, err := c.Init(options); err != nil { return err } diff --git a/docs/book/src/developer/providers/v1.3-to-v1.4.md b/docs/book/src/developer/providers/v1.3-to-v1.4.md index 505818ef6f0c..96c16bdd4fd6 100644 --- a/docs/book/src/developer/providers/v1.3-to-v1.4.md +++ b/docs/book/src/developer/providers/v1.3-to-v1.4.md @@ -21,6 +21,7 @@ maintainers of providers and consumers of our Go API. ### Removals - `clusterctl backup` has been removed. +- The option `--list-images` from `init` subcommand has been removed. ### API Changes