Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure dependencies #216

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Update Azure dependencies #216

merged 2 commits into from
Jul 19, 2019

Conversation

justaugustus
Copy link
Contributor

@justaugustus justaugustus commented Jun 11, 2019 •
edited
Loading

Signed-off-by: Stephen Augustus saugustus@vmware.com

What this PR does / why we need it:
Update Azure dependencies

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Azure SDK APIs bump:

  • network --> 2019-04-01 (includes Azure Bastion API)
  • resources --> 2019-05-01

Release note:

Update Azure dependencies
- github.com/Azure/azure-sdk-for-go v31.1.0
- github.com/Azure/go-autorest/autorest v0.5.0
- github.com/Azure/go-autorest/autorest/azure/auth v0.1.0
- github.com/Azure/go-autorest/autorest/to v0.2.0
- github.com/Azure/go-autorest/autorest/validation v0.1.0

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 11, 2019
@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Jun 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2019
@justaugustus
Copy link
Contributor Author

/hold
/milestone v1alpha1
/priority important-soon
/kind feature

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Jun 11, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 11, 2019
@justaugustus justaugustus mentioned this pull request Jun 25, 2019
Closed
@justaugustus
Copy link
Contributor Author

Opened an issue upstream for this dependency failure: Azure/go-autorest#413

@justaugustus justaugustus mentioned this pull request Jul 11, 2019
Merged
@tamalsaha
Copy link

FWIW, I am also stuck on this issue and added my findings here: Azure/go-autorest#413 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2019
@justaugustus justaugustus changed the title Update Azure dependencies (6/10/19) Update Azure dependencies Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 19, 2019
@justaugustus
Copy link
Contributor Author

Thanks for the tips, @tamalsaha!

I ended up initially setting:

require (
        <snip>
        github.com/Azure/go-autorest v12.3.0
        <snip>
)

replace (
	github.com/Azure/go-autorest => github.com/Azure/go-autorest v12.3.0
        <snip>
)

which updated to this after running ./hack/update-vendor.sh:

require (
        <snip>
	github.com/Azure/go-autorest/autorest v0.5.0
	github.com/Azure/go-autorest/autorest/azure/auth v0.1.0
	github.com/Azure/go-autorest/autorest/to v0.2.0
	github.com/Azure/go-autorest/autorest/validation v0.1.0 // indirect
        <snip>
)

replace (
	github.com/Azure/go-autorest => github.com/Azure/go-autorest v12.3.0+incompatible
        <snip>
)

/hold cancel
/assign @soggiest @awesomenix @juan-lee

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2019
@awesomenix
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2019
@justaugustus
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2019
@justaugustus
Update Azure dependencies
93cceb1 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Bump vendor
3892519 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2019
@justaugustus
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2019
@awesomenix
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit a31c531 into kubernetes-sigs:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awesomenix awesomenix Awaiting requested review from awesomenix

@serbrech serbrech Awaiting requested review from serbrech

Assignees

@awesomenix awesomenix

@soggiest soggiest

@juan-lee juan-lee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @tamalsaha @awesomenix @soggiest @juan-lee