Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test coverage for spot instances #1893

Closed
ncdc opened this issue Aug 27, 2020 · 1 comment · Fixed by #1963
Closed

Add e2e test coverage for spot instances #1893

ncdc opened this issue Aug 27, 2020 · 1 comment · Fixed by #1963
Assignees
@gab-satchi
Labels
area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
v0.6.5

Comments

@ncdc
Copy link
Contributor

ncdc commented Aug 27, 2020

#1868 added support for spot instances. It would be nice to update our e2e tests to test spot instances to ensure they continue to function and future changes don't accidentally introduce regressions.
@ncdc ncdc added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/testing Issues or PRs related to testing labels Aug 27, 2020
@randomvariable randomvariable added this to the v0.6.x milestone Sep 21, 2020
@gab-satchi
Copy link
Member

/assign

@gab-satchi gab-satchi mentioned this issue Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gab-satchi gab-satchi

Labels
area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
v0.6.5
Development

Successfully merging a pull request may close this issue.

🌱 Adds e2e test for spot instances gab-satchi/cluster-api-provider-aws
3 participants
@ncdc @randomvariable @gab-satchi