Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging framework selection #32

Closed
jkachmar opened this issue Feb 26, 2019 · 4 comments
Closed

Logging framework selection #32

jkachmar opened this issue Feb 26, 2019 · 4 comments

Comments

@jkachmar
Copy link

Currently the haskell-http-client OpenAPI generator selects one of katip or monad-logger when generating the client functions.

Perhaps this is too much additional complexity, but it seems like it wouldn't be too much extra effort for the upstream haskell-http-client to generate both {{baseModule}}.Logging.MonadLogger and {{baseModule}}.Logging.Katip, make {{baseModule}}.Logging a re-export of one of the two (based on some CPP directive), and add a flag to the cabal file that toggles the CPP directive and selects other-modules/exposed-modules.


I'm opening the issue to this tracket simply because this is the most active consumer of the haskell-http-client generator that I'm aware of, so I imagine peoples' opinions here would be the most informed.

@jkachmar
Copy link
Author

cc @jonschoning

@jonschoning
Copy link
Contributor

I think that's doable.

I was also thinking about removing katip completely, but I could also just make monad-logger the default option in the above scenario.

@jonschoning
Copy link
Contributor

jonschoning commented Feb 27, 2019

OpenAPITools/openapi-generator#2258 implements these changes

@jkachmar
Copy link
Author

jkachmar commented Mar 7, 2019

This looks like it's been addressed, but I'll leave the issue open until we've merged the changes introduced by kubernetes-client/gen#108 that gives us access to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants