Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting tf-job through the dashboard is not working #1019

Closed
karthikv2k opened this issue May 28, 2019 · 6 comments
Closed

Deleting tf-job through the dashboard is not working #1019

karthikv2k opened this issue May 28, 2019 · 6 comments
Labels

Comments

@karthikv2k
Copy link

When i tried to delete a tf-job through tf-job dashboard. I get a message saying "Are you sure you want to delete TFJob "test" in namespace "test"?"

Screen Shot 2019-05-28 at 2 07 48 PM

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.95. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@richardsliu richardsliu mentioned this issue Jun 7, 2019
4 tasks
@richardsliu
Copy link
Contributor

I think I know what's going on.

The message is just misleading - looks like it is hardcoded.

Also for deletion to work, the user needs to actually click on the TFJob to delete. This means that the URL should be something like

http://127.0.0.1:8080/api/v1/namespaces/kubeflow/services/tf-job-dashboard/proxy/tfjobs/ui/#/[namespace]/[name]

instead of just

http://127.0.0.1:8080/api/v1/namespaces/kubeflow/services/tf-job-dashboard/proxy/tfjobs/ui/#/

If either the namespace or name is missing in the request, the deletion will fail.

@jlewi
Copy link
Contributor

jlewi commented Jun 10, 2019

Is the TFJob dashboard worth keeping?

@richardsliu
Copy link
Contributor

Moving this out of 1.0 since the dashboard is being deprecated.

Will reconsider this in 0.7 if there is a demand to bring back the dashboard.

@richardsliu
Copy link
Contributor

I think we can close this now since the dashboard is deprecated.

/close

@k8s-ci-robot
Copy link

@richardsliu: Closing this issue.

In response to this:

I think we can close this now since the dashboard is deprecated.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants