From 834d157f6c33963d208d8f0332c0de7b2fb8de06 Mon Sep 17 00:00:00 2001
From: Riley Bauer <rjbauer@google.com>
Date: Mon, 5 Nov 2018 10:36:25 -0800
Subject: [PATCH] Refresh button now reloads logs and artifacts as well on
 RunDetails page

---
 frontend/src/pages/RunDetails.tsx | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/frontend/src/pages/RunDetails.tsx b/frontend/src/pages/RunDetails.tsx
index 453c3e8f794..bda71897da5 100644
--- a/frontend/src/pages/RunDetails.tsx
+++ b/frontend/src/pages/RunDetails.tsx
@@ -318,6 +318,11 @@ class RunDetails extends Page<RunDetailsProps, RunDetailsState> {
       await this.showPageError(`Error: failed to retrieve run: ${runId}.`, err);
       logger.error('Error loading run:', runId);
     }
+
+    // These are called here to ensure that logs and artifacts in the side panel are refreshed when
+    // the user hits "Refresh", either in the top toolbar or in an error banner.
+    this._loadSelectedNodeLogs();
+    this._loadSelectedNodeOutputs();
   }
 
   private _selectNode(id: string) {
@@ -354,8 +359,6 @@ class RunDetails extends Page<RunDetailsProps, RunDetailsState> {
   private async _loadSelectedNodeOutputs() {
     const selectedNodeDetails = this.state.selectedNodeDetails;
     if (!selectedNodeDetails) {
-      // This should never happen
-      logger.error('Tried to load outputs for a node that is not selected');
       return;
     }
     this.setState({ sidepanelBusy: true });
@@ -379,8 +382,6 @@ class RunDetails extends Page<RunDetailsProps, RunDetailsState> {
   private async _loadSelectedNodeLogs() {
     const selectedNodeDetails = this.state.selectedNodeDetails;
     if (!selectedNodeDetails) {
-      // This should never happen
-      logger.error('Tried to load outputs for a node that is not selected');
       return;
     }
     this.setState({ sidepanelBusy: true });